board:tricorder: always work with valid eeprom data
authorAndreas Bießmann <[email protected]>
Thu, 10 Apr 2014 10:52:50 +0000 (12:52 +0200)
committerTom Rini <[email protected]>
Fri, 11 Apr 2014 14:08:42 +0000 (10:08 -0400)
Commit 890880583d84607e36b52a785a96b167728bbf73 introduced EEPROM parsing and
board detection but faild to return a valid tricorder_eeprom struct for backup
case.  When pressing S200 while reading EEPROM we ignore the value. We
returned falsely a tricorder_eeprom struct with uninitialized data which is
just garbage.
Initialize it by zeroing the whole structure.

Signed-off-by: Andreas Bießmann <[email protected]>
Cc: Thomas Weber <[email protected]>
Signed-off-by: Andreas Bießmann <[email protected]>
board/corscience/tricorder/tricorder.c

index 2dfcb271d326812b01343715c4a09dfbfc8c743f..9e81bf3f3f94f645ac70563ad2c7563744b9d2b7 100644 (file)
@@ -79,6 +79,8 @@ static void get_eeprom(struct tricorder_eeprom *eeprom)
                } else {
                        panic("Could not get board revision\n");
                }
+       } else {
+               memset(eeprom, 0, TRICORDER_EEPROM_SIZE);
        }
 }